Well he does sell more armor with time but you can resurrect him afterwards with some souls so there is no real downside to killing him. This goes with all npcs in scholar pf the first sin and once an npc dies there will be nothing there but travel a few times through the bonfire or do some questing stuff and a grave stone will appear where that npc once was.