{{
`${userDetail.user.displayName}${userDetail.user.cachedBungieGlobalDisplayNameCode ? `#${standardizeBungieGlobalCode(userDetail.user.cachedBungieGlobalDisplayNameCode)}` : ""}`}}
{{getUserClans()}}
5/24/2015 1:27:25 PM
8
I've always said that Bungies coding skills are subpar, and this is another reason why.
English
-
Bungie is clearly terrible at coding. Remember that ball that was in the tower? And this "new" ball that lights up when you kick it? [spoiler]I think they're the same ball.[/spoiler]
-
That is perfectly par, the program works fine. I have had experience with programming and let me tell you. If there is a way you can reuse code, you WILL reuse it
-
No, it's shit coding. The idea behind reuse is that you encapsulate what changes so you can re-use what doesn't. Clearly in this case, oracle-ness was not encapsulated, and got treated as if it didn't, when in fact it does.
-
What is wrong with this coding? Why reinvent the wheel? I think it ads more to the game as it give you more reasons to equip different weapons and builds
-
You've actually asked two questions here: 1: why isn't it good to re-use code like this? Why re-invent the wheel? - Because sometimes you need a steering wheel. - Not all re-use is good. Re-use is good when you encapsulate one specific thing, and use it in the same context in many places. Say you use routine X inside Y and Z, so Y and Z are more compact, and when you fix X, you also fix Y and Z. That's good re-use. This is not what happened here. What happened here is taking X and using it inside Y and B, so when you fix X you fix Y and break B. Now someone writing code that deals with A, B and C needs to know about X, Y and Z, because you've coupled them unnecessarily. I highly recommend reading the Strategy Pattern (ducks) chapter of Head-first Design Patterns, as this explains good reuse and bad reuse a lot better and more convincingly than I just did, and you can read it online for free. https://www.safaribooksonline.com/library/view/head-first-design/0596007124/ch01.html Read about the ducks, and you'll realise what was done badly in this instance of reuse. 2: what's wrong with this behaviour in the context of the game? - What's wrong with this behaviour in the context of the game is that the fluff on the weapons is that you won them, through heroic effort, from the Vault of Glass, and they have special (possibly supernatural) effects on the Vex constructs found there. That they should also work on something that isn't from the Vault of Glass and has nothing to do with it contradicts the story.
-
Wow you really did your research. But I still don't think of it as a mistake in fact I hope they keep it like this
-
This. Good programmers actually design their code to be reusable. It saves a lot of time and effort.
-
This...no point in reinventing the wheel
