originally posted in:BungieNetPlatform
Starred on github. This is great. Couple questions:
Have you rate limited the application, or at least, absorb Bungie's rate limiting errors?
Are you planning to keep this up to date? Bungie's api changes often enough.
Third, can you go back in time and have this ready on Destiny launch date so I don't have to write the huge mess I wrote :)
English
-
[quote]Have you rate limited the application, or at least, absorb Bungie's rate limiting errors?[/quote] Not yet. I have a few ideas: 1. Enable rate limiting, logging, and other such concerns via a) decorators for BaseJump.Service or b) injection of a decorated request handler 2. Handle errors returned in the message wrapper in some way. Need to look into best practices with the Task system, but my first inclination is to create an event on the service. [quote]Are you planning to keep this up to date? Bungie's api changes often enough.[/quote] I spent a significant amount of time creating the library that makes it easy to map a REST service. Keeping the signatures up-to-date is as easy as changing the method signature, maybe the route attribute, and the anonymous object acting as a model. The DTOs might require significant work when the API changes, but it's pretty straightforward since they're POCOs. But to actually answer your question: yes. However, if no one is using it but me, then I'm going to take my time. If others are using it, I will be timely. If a tool I use as a player uses it, I'll tell my raid groups to find another player till I get it done. [quote]Third, can you go back in time and have this ready on Destiny launch date so I don't have to write the huge mess I wrote :)[/quote] [i]Atheon opens the timestream[/i]. It just never occurred to me to do this until a couple of weeks ago. Out of curiosity, I looked for your code, but I couldn't find it. Is it open source?
-
Are you still actively updating this code?