i activated my cross save and it even says it was activated but when i try and play on PC it is making me make a new character. I was trying to get my stuff from my ps4 to my PC characters wise.
As suttungur said, you may be signing in to the incorrect Steam account, or you possibly linked the wrong one to Cross Save. You can verify this by loading up the game on Steam, typing /id, and seeing if it matches this: 76561198951175210
If not, then the Steam account you have linked is different from the account you're signing into.
Are you aware if you have multiple Steam accounts? If so, sign into your other one and see if your characters appear there. If not, go through the password recovery process, and after inputting your email you may see that you have another account under that address.
You do have the cross-save set up as PSN being your main, so it should work. One reason for not seeing characters would be that you may be logging into the wrong Steam account.