So I bought the season pass because it told me that was the only thing that I needed.. now I reached the second mission and now I need to pay another 35 dollars.. so why did I buy the season pass if the dlc already comes with it .. so basically if I end up buying the dlc I’ve wasted money because I bought the season pass first ?
Shadowkeep is the main DLC that came out on October 1st. The Season Passes grant access to premium Season content.
The two are entirely different things and work separately from each other. You don't need Shadowkeep to purchase access Season Pass content, and you don't need a Season Pass to access Shadowkeep content.
The Shadowkeep packages do, however, come with bonus Season Passes for owning them, and that's elaborated on below for you.
With that being said, please take note of the following:
Year 3 Season Passes granted as a bonus for purchasing the DLCs will apply up through Season 11, and then beyond that will be converted into equivalent Silver.
So, for your circumstance, the two following are options:
1) You can purchase the Shadowkeep Standard package that comes with a free Season Pass. Since you already own the Season Pass for Season 8, its bonus Season Pass will apply towards Season 9 (next Season). You didn't waste any Silver (unless you end up not liking Season 9 in the future).
2) You can purchase the Shadowkeep Deluxe package that comes with 4 bonus Season Passes. Since you already own the Season Pass for Season 8, those 4 bonus Season Passes will apply to Season 9, 10, and 11. Because there's still one more Season Pass to apply and it cannot, that Season Pass will be converted into 1000 Silver (which just so happens to be the same amount you spent to purchase the Season Pass you already got). It effectively gives you back your 1000 Silver that you spent on the Season Pass you already purchased, which still means you didn't waste any Silver.
I hope this information helps you out.